Line chart doesn't redraw correctly after removeEntry()

[jscalo]

If you add a few entries to a line chart and have for e.g. this:

Then remove the entry at index 2 ("83") and you get something like this:

Clearly the chart isn't redrawing correctly. The old grid line is still there and the space where the old value was didn't condense. Here's a sample project to demonstrate:

ChartsRemoveBug.zip

(You'll need to add the Charts directory to the top level…)

This sounds very similar to #745 which was closed after the bug mysteriously stopped happening to the originator.

[liuxuan30]

You call removeEntry at data set level, which seems not correct, try call chartData.removeEntry(xValue: Double, dataSetIndex: Int) -> Bool
It will recalculate the min/max value at data level to adjust the axis if necessary.

[jscalo]

Hi Xuan,

I get the exact same behavior when using chartData.removeEntry(xValue: Double, dataSetIndex: Int) -> Bool.

Here's the exact code:

self.chart.data?.removeEntry(xValue: Double(self.removeTextField.text!)!, dataSetIndex: 0)
self.chart.data?.notifyDataChanged()
self.chart.notifyDataSetChanged()

Can you please reopen until we both agree this is addressed?

As an aside, isn't

func removeEntry(xValue: Double, dataSetIndex: Int) -> Bool

wrongly declared? If xValue is intended to be an index then a) it should be named xIndex and b) it should be an Int.

Thanks!

[liuxuan30]

Since chart 3.0, x axis is same as y axis almost. So taking double is correct. The question is, has it remove the entry you want?
What does not work? It's supposed to recalculate the axis range and render the line again. If the entry you removed is the not min/max value, it should have no impact then.

[jscalo]

What does not work?

The issue is exactly as I originally described it— the point is removed but the graph is not redrawn. The old grid line is still there and the x axis doesn't "squeeze in". I attached a sample project to the original description so you can reproduce it easily.

[liuxuan30]

If you are talking about your screenshots, I'd say it's expected from my side. The '83' point is not connected, and 96 directly connected to whatever '8' is on the right edge.

About the x axis 'squeeze in', I don't see any reason for it, as the x axis range is not changed, right? You removed one entry, whose x value is neither min nor max, so the x axis should not change.

You seem take x axis as indexed based axis just like chart 2.x, but in chart 3.0, the x axis behaves like y axis. You can -1 for the rest of your entries' x value, so it will squeeze in I suppose.

[jscalo]

Yeah, the x values are indexed in this case so I'd need to go through all the subsequent x values and decrement them by 1 to get that effect. That makes sense. Sorry for misunderstanding!