Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate Memory Leak #2523

Closed
MikasaAckerman opened this issue Jun 15, 2017 · 2 comments
Closed

Delegate Memory Leak #2523

MikasaAckerman opened this issue Jun 15, 2017 · 2 comments

Comments

@MikasaAckerman
Copy link

MikasaAckerman commented Jun 15, 2017

lineChartView.delegate = self
lineChartView.xAxis.valueFormatter = self

if this two lines are added,deinit() isn't executed……
sorry,how to do 啊……

@MikasaAckerman
Copy link
Author

MikasaAckerman commented Jun 15, 2017

sorry to open the issue.
i have solved this problem by

override func viewWillDisappear(_ animated: Bool) {
        super.viewWillDisappear(animated)
        
        lineChartView.delegate = nil
        lineChartView.xAxis.valueFormatter = nil
}

sorry to bother you...

@paktree
Copy link

paktree commented Nov 15, 2017

We ran into this issue also. To me, this feels like an issue with the valueFormatter not having weak property. Could this be fixed in the SDK instead of setting those values to nil in the dealloc/viewWillDisappear function?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants