Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak when valueFormatter is set #2652

Closed
ehsan-black opened this issue Jul 29, 2017 · 1 comment
Closed

Memory leak when valueFormatter is set #2652

ehsan-black opened this issue Jul 29, 2017 · 1 comment

Comments

@ehsan-black
Copy link

ehsan-black commented Jul 29, 2017 •
edited

Hi,
When I set a value formatter for Axis my viewController stays in memory forever.
I think the problem is in AxisBase Class where _axisValueFormatter is not a weak var:

fileprivate var _axisValueFormatter: IAxisValueFormatter?

https://github.com/danielgindi/Charts/blob/master/Source/Charts/Components/AxisBase.swift#L25
@ehsan-black
Copy link
Author

sorry it seems to be a duplicate of 2039

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ehsan-black