Candlestick doesn't work when x does not start at 0

[mannyveloso]

What did you do?

We're attempting to make a candlestick graph where the x-axis is a date value. We added a datevalueformatter so the x-axis would display DD-MMM-YYYY.

What did you expect to happen?

The date formatter would display the date on the x-axis.

What happened instead?

The graph axis labels were 01-Jan-1970. In addition, the candlestick graph was drawn oddly. The red dot that was normally there was gone.

From a quick look at the code, the renderer seems to assume that x is a monotonically increasing value that starts at 0.

Charts Environment

Charts version/Branch/Commit Number:
Charts 3.1.1
Xcode 9.3
Swift 4.1
iOS 11.3
Mac OS 10.13.4

[liuxuan30]

take a look at the demo. You can workaround by modifying the value formatter to start from 0.

And what number you start with?

I checked the code, no matter what your X val is, when rendering, it should maps to Xbounds starting from 0. So it should be transparent.

I tweaked the Chart demo to

        [yVals1 addObject:[[CandleChartDataEntry alloc] initWithX:i+5 shadowH:val + high shadowL:val - low open:even ? val + open : val - open close:even ? val - close : val + close icon: [UIImage imageNamed:@"icon"]]];

and it sill draws fine.

(lldb) po _xBounds.min
0

(lldb) po _xBounds.max
40

(lldb) po _xBounds.range
40

(lldb) po dataSet.xMin
5.0

(lldb) po dataSet.xMax
45.0

[liuxuan30]

post more details and images and reopen it.

[mannyveloso]

So, this image is when the x coordinate is a straight-up 0-1-2-3-4-5-etc.

The next image is when the x-coordinate is the time since 1970. The red bars are missing and it's oddly offset.

[mannyveloso]

Can't reopen the issue. Should I just open a new issue?

[mannyveloso]

Dup of #1742