Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiling Chart with Swift 5.1 raises compilation error #4090

Closed
1 task done
aqjune opened this issue Aug 5, 2019 · 5 comments
Closed
1 task done

Compiling Chart with Swift 5.1 raises compilation error #4090

aqjune opened this issue Aug 5, 2019 · 5 comments

Comments

@aqjune
Copy link

aqjune commented Aug 5, 2019

What did you do?

ℹ Compiling Chart with Swift 5.1 raises compilation error

What did you expect to happen?

ℹ Compiles successfully

What happened instead?

ℹ Has following errors:

~/Charts/Source/Charts/Utils/ChartUtils.swift:76:22: error: static member 'log10' cannot be used on instance of type 'Double'
        let d = ceil(log10(self < 0 ? -self : self))
                     ^~~~~
                     Double.
~/Charts/Source/Charts/Utils/ChartUtils.swift:98:26: error: static member 'log10' cannot be used on instance of type 'Double'
        return Int(ceil(-log10(i))) + 2 
                         ^~~~~
                         Double.

Charts Environment

Charts version/Branch/Commit Number:: 8c28cfa
Swift version:: swift-DEVELOPMENT-SNAPSHOT-2019-07-30-a.xctoolchain

@liuxuan30
Copy link
Member

we don't handle beta versions.

@BinaryHammer
Copy link

BinaryHammer commented Sep 25, 2019

@liuxuan30 Now Swift 5.1 is released. See Swift.org

@liuxuan30
Copy link
Member

I have merged #4153

@BinaryHammer
Copy link

@liuxuan30 Yay it works again in my macOS app. Thanks.

@liuxuan30
Copy link
Member

liuxuan30 commented Sep 27, 2019

yep, but pod still need wait. I have two issues pending before releasing a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants