You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support to set a custom width to an y axis as described in #92 .
Note that this only works with values that are greater than the longest label width.
It takes the max from the longest label and the custom width.
What do we need this for? If you've got several charts that share the same x values vertically stacked in a view, setting a common y axis width based on the widest y axis not only looks nicer, it also allows you to get away with a single x axis (that is, in case the chart ranges are kept in sync of course).
I'm improving it to have a max and a min width, and then merging it in.
By the way, you should really make branches for your PRs, so you can have separate PRs. (Create a branch, make whatever changes, create PR. Then go back and branch from the same spot and make another)
Ok, sounds even better.
Regarding the branching, do you have any difficulties with merging these pull requests the way I do them now? I usually pull from your master branch before implementing my changes and create the pull request from that, so (ideally) there shouldn't be any conflicts when you merge them, at least I hope so.
However, if branching makes it easier for you, then I'll do that of course.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support to set a custom width to an y axis as described in #92 .
Note that this only works with values that are greater than the longest label width.
It takes the max from the longest label and the custom width.
What do we need this for? If you've got several charts that share the same x values vertically stacked in a view, setting a common y axis width based on the widest y axis not only looks nicer, it also allows you to get away with a single x axis (that is, in case the chart ranges are kept in sync of course).