Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor typo fix in console alert message "it's" -> "its" #2301

Merged
merged 1 commit into from Apr 2, 2017
Merged

Minor typo fix in console alert message "it's" -> "its" #2301

merged 1 commit into from Apr 2, 2017

Conversation

simonbromberg
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #2301 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2301      +/-   ##
==========================================
+ Coverage   18.44%   18.58%   +0.14%     
==========================================
  Files         124      124              
  Lines       14619    14508     -111     
==========================================
  Hits         2696     2696              
+ Misses      11923    11812     -111
Impacted Files Coverage Δ
Source/Charts/Charts/PieRadarChartViewBase.swift 0% <0%> (ø) ⬆️
Source/Charts/Charts/BarLineChartViewBase.swift 25.12% <0%> (+1.68%) ⬆️
Source/Charts/Utils/Platform.swift 15.38% <0%> (+2.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa22439...3f285e8. Read the comment docs.

@@ -23,4 +23,4 @@ then
build_dependencies
else
alert_to_install_carthage
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this matter? Sometimes I see such diff but not sure why introduced.

@danielgindi
Copy link
Collaborator

danielgindi commented Apr 2, 2017

This is not a typo. Please learn English grammar...


Sorry, I read the diff wrong. Though that "its" was the original.

@danielgindi danielgindi closed this Apr 2, 2017
@simonbromberg
Copy link
Contributor Author

"it's" is a contraction of "it is"

"its" is a possessive determiner

So unless the sentence is supposed to read "In order to build Charts you need to use Carthage to build it is dependencies" then yes, it's a typo.

@danielgindi
Copy link
Collaborator

Well, my bad. I looked at the diff the other way around. Thought that the original was "its" :-)

@danielgindi danielgindi reopened this Apr 2, 2017
@danielgindi danielgindi merged commit f23e872 into ChartsOrg:master Apr 2, 2017
PeterSrost pushed a commit to sokol8/Charts that referenced this pull request Oct 31, 2018
Minor typo fix in console alert message "it's" -> "its"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants