datetime support in .from_dict() #33
Labels
bug
Something isn't working
good first issue
Good for newcomers
low priority
small
Low effort issue that can easily be picked up
Projects
Milestone
Good day, assuming I have
d = {'date_of_birth': datetime.datetime(2000)}
and a
proto
includingdate_of_birth: Timestamp
:When
proto.from_dict(d)
is called, it assumes the value of date_of_birth is an ISO string and does not consider that it may already be adatetime.datetime
I refer to your
__init__.py
L799-803:This should check if
value[key]
is already an instance ofdatetime.datetime
and assign it directly, shouldn't it?The text was updated successfully, but these errors were encountered: