Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional fields in proto3 #574

Closed
3 tasks done
dpkristensen opened this issue Apr 29, 2024 · 6 comments
Closed
3 tasks done

Optional fields in proto3 #574

dpkristensen opened this issue Apr 29, 2024 · 6 comments
Labels
duplicate This issue or pull request already exists

Comments

@dpkristensen
Copy link

Summary

Unsupported optional fields in proto3

Reproduction Steps

Run the generator on a .proto file using proto3 and an optional field.

Expected Results

Proto file is generated

Actual Results

Message "code generator protoc-gen-python_betterproto hasn't been updated to support optional fields in proto3" is displayed.

System Information

libprotoc 26.0 Python 3.11.7 Name: betterproto Version: 1.2.5 Summary: A better Protobuf / gRPC generator & library Home-page: http://github.com/danielgtaylor/python-betterproto Author: Daniel G. Taylor Author-email: danielgtaylor@gmail.com License: MIT Location: C:\Python311\Lib\site-packages Requires: grpclib, stringcase Required-by:

Checklist

  • I have searched the issues for duplicates.
  • I have shown the entire traceback, if possible.
  • I have verified this issue occurs on the latest prelease of betterproto which can be installed using pip install -U --pre betterproto, if possible.
@dpkristensen dpkristensen added bug Something isn't working investigation needed labels Apr 29, 2024
@Gobot1234 Gobot1234 added duplicate This issue or pull request already exists and removed bug Something isn't working investigation needed labels Apr 29, 2024
@Gobot1234
Copy link
Collaborator

This is already supported on main

@Gobot1234 Gobot1234 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 29, 2024
@dpkristensen
Copy link
Author

@Gobot1234 When will the update be published? Last update on pypi was 4 years ago.

@Gobot1234
Copy link
Collaborator

I have verified this issue occurs on the latest prelease of betterproto which can be installed using pip install -U --pre betterproto, if possible.

@dpkristensen
Copy link
Author

Sorry I misread that text. But my question is about when a new release will occur; pypi shows the CI status is "failing" and I would like not to add a dependency to something which may break in the future.

@Gobot1234
Copy link
Collaborator

There is no current release date for a full release of V2. The CI failing isn't for V2 I wouldn't worry about it

@dkbarn
Copy link

dkbarn commented Jun 9, 2024

I think it's a valid concern for users of this library to ask whether it has been abandoned before fully committing to integrating it into any project. It sounds like all focus is on V2, which is unreleased and only available via the --pre flag. Meanwhile, no features or bugfixes have been backported to V1 in over 4 years. Why is that? It's unusual to expect all users to install your package with --pre indefinitely, while abandoning support of the stable version of the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants