Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: add support for deflate encoding #205

Closed
aharpervc opened this issue Jul 26, 2023 · 2 comments · Fixed by #210
Closed

Request: add support for deflate encoding #205

aharpervc opened this issue Jul 26, 2023 · 2 comments · Fixed by #210
Labels
enhancement New feature or request

Comments

@aharpervc
Copy link

Hi, I've started playing with restish, very cool project!

My request is to add support for deflate encoding. I see by default the accept-encoding header is br,gzip but I'm working with an API that only supports deflate.

I confirmed that I can override that header with a persistent header in my config file, but that results in an error: Caught error: unsupported content-encoding deflate

@danielgtaylor danielgtaylor added the enhancement New feature or request label Aug 2, 2023
@aharpervc
Copy link
Author

Hi, thanks for adding this feature. I've now been able to revisit restish since you added it. I noticed that with my API, the response body is no longer printed when the response is deflate encoded. I can add --rsh-header 'accept-encoding:identity' and the response body is printed as normal. With --rsh-verbose, I see various ascii codes dumped out with <?>'s, I'm guessing that's the raw response, and DEBUG: Decoding response from deflate. No errors are indicated.

Is this expected? Can restish be configured to show the response body after decompression?

@aharpervc
Copy link
Author

@danielgtaylor thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants