Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest canmatrix version to support DBCs with mix of J1939/Standard IDs #930

Closed
MatinF opened this issue Oct 23, 2023 · 1 comment
Closed

Update to latest canmatrix version to support DBCs with mix of J1939/Standard IDs #930

MatinF opened this issue Oct 23, 2023 · 1 comment

Comments

@MatinF
Copy link
Contributor

MatinF commented Oct 23, 2023

As per ebroecker/canmatrix#729

It seems the GUI is unable to handle DBC files with mixed signals (i.e. both J1939 PGNs and e.g. standard 11-bit IDs or 29-bit IDs). Potentially this relates to the GUI/canmatrix relying on the ProtocolType field to determine if a DBC is J1939 or not, rather than basing it off the vFrameFormat attribute marking a specific message ID as a J1939PG type or not.

Seemingly the issue is not replicable in the latest canmatrix code, but it appears to be an issue in the latest asammdf GUI release 7.3.16, making me assume it's related to the asammdf GUI being dependent on an older canmatrix version.
This was referenced Oct 23, 2023
Closed
Closed
@MatinF
Copy link
Contributor Author

MatinF commented Oct 24, 2023

This seems to be resolved in the latest development code, thanks!

@MatinF MatinF closed this as completed Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MatinF