Improve back button on course layout #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tton-on-course-layout
valeriaxxx
added
enhancement
danieljancar
requested changes
Mar 7, 2024
| @@ -40,7 +40,7 @@ | |||
| </ul> | |||
| } | |||
| </div> | |||
| <a class="btn btn-ghost text-xl" routerLink="/"> | |||
| <a class="btn btn-ghost text-xl" href="{{link}}"> | |||
There was a problem hiding this comment.
Use routerLink instead of href, it's used for internal routing. Href is normally used for routings outside of the website. https://angular.dev/guide/routing/router-reference#active-router-links
apps/course/src/app/app.component.ts
Outdated
| @@ -48,3 +48,7 @@ export class AppComponent { | |||
| }); | |||
| } | |||
| } | |||
|
|
|||
| export const Link = { | |||
There was a problem hiding this comment.
Can't this be moved in the navbar-course.component itself, since it's only used in the course-layout back button and not in the whole app?
| @@ -40,7 +40,7 @@ | |||
| </ul> | |||
| } | |||
| </div> | |||
| <a class="btn btn-ghost text-xl" routerLink="/"> | |||
| <a class="btn btn-ghost text-xl" routerLink="/../../../../../{{link}}"> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Checklist:
Description
Programmed the button to go to the previous page before a specific course. It goes back to either the Homepage or the Course page.