Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need tests for sink_radiation functionality #540

Closed
danieljprice opened this issue May 3, 2024 · 1 comment · Fixed by #542
Closed

Need tests for sink_radiation functionality #540

danieljprice opened this issue May 3, 2024 · 1 comment · Fixed by #542

Comments

@danieljprice
Copy link
Owner

given #538 we should have something in the test suite that checks that the wind with sink radiation cannot be broken by code changes. Ideally a test of the wind with radiation pressure against an analytic solution?
@lsiess
Copy link
Contributor

lsiess commented May 4, 2024

will do it but I don't think there is an analytic solution.

@danieljprice danieljprice mentioned this issue May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wind test including radiation force + ieos = 17 + bug fixes lsiess/phantom
2 participants
@danieljprice @lsiess