New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neos 5.x incompatibility #6

Open

bwaidelich opened this issue Jul 10, 2020 · 1 comment

bwaidelich commented Jul 10, 2020

Version 1.3.0 claims to be compatible with Neos 5.0 but it's not fully adjusted to the PSR 7 changes, i.e. line
https://github.com/daniellienert/assetsource-mediawiki/blob/master/Classes/Api/MediaWikiClient.php#L184
should be adjusted to sth like

$resultData = \GuzzleHttp\json_decode($result->getBody()->getContents(), true);

(or a backwards compatible version of it)

Owner

daniellienert commented Jul 11, 2020 •

edited

Hey @bwaidelich, thanks for reporting.

There is some strangeness:

Everything works great for me on Neos master, just tested every feature
This feature should not depend on the Neos version, as I use pure guzzle here

I Added the missing getContents() - would you test it again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment