Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider contributing some rules up to typescript-eslint? #665

Closed
JoshuaKGoldberg opened this issue Nov 8, 2022 · 4 comments
Closed

Consider contributing some rules up to typescript-eslint? #665

JoshuaKGoldberg opened this issue Nov 8, 2022 · 4 comments

Comments

@JoshuaKGoldberg
Copy link

Hi! I found this plugin recently and really like it 馃槃 thanks for making it! Some of the rules seem pretty generally useful:

  • total-functions/no-unsafe-type-assertion: the stronger form of objectLiteralTypeAssertions might be good to pull in as an option for @typescript-eslint/consistent-type-assertion?
  • total-functions/no-unsafe-readonly-mutable-assignment & total-functions/no-unsafe-mutable-readonly-assignment: I've been hit by this before!
  • total-functions/no-unsafe-optional-property-assignment: Also broadly useful, once [no-unsafe-optional-property-assignment] too noisy聽#83 lands

Would you be open to having these rules taken into typescript-eslint itself? We'd want to have issues filed on github.com/typescript-eslint/typescript-eslint for each to discuss, but since they've been proven useful by this plugin I'd be surprised if there were any holdups. 馃槃

@danielnixon
Copy link
Owner

They're all yours @JoshuaKGoldberg

@danielnixon
Copy link
Owner

Do watch out for #192 and some other gnarly issues though. Fixes welcome.

@JoshuaKGoldberg
Copy link
Author

Filed issues over on github.com/typescript-eslint/typescript-eslint! 馃殌

Note that I didn't file one for total-functions/no-unsafe-mutable-readonly-assignment. Per the README.md it's quite noisy in practice. If someone else feels strongly that it's useful and should be added to typescript-eslint core, I'd encourage them to file an issue too 馃槃.

@JoshuaKGoldberg JoshuaKGoldberg changed the title Consider contributing some functions up to typescript-eslint? Consider contributing some rules up to typescript-eslint? Feb 17, 2024
@JoshuaKGoldberg
Copy link
Author

Closing out my old issues for repos I no longer have context on. If anybody has a need for what this issue was asking about, I'd encourage them/you to file a new issue. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants