Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue generating coverage with AttributeFilter #146

Closed
manemarron opened this issue Jul 27, 2018 · 2 comments
Closed

Issue generating coverage with AttributeFilter #146

manemarron opened this issue Jul 27, 2018 · 2 comments
Labels

Comments

@manemarron
Copy link

I have many test projects in my solution so I am using AltCover as my coverage calculator for each project and ReportGenerator (https://github.com/danielpalme/ReportGenerator) as my coverage aggregator. When I run

$  dotnet test /p:AltCover=true /p:AltCoverAttributeFilter=ExcludeFromCodeCoverage
$ dotnet reportgenerator "-reports:coverage.xml" "-targetdir:coverage" "-reporttypes:Html;Xml"

on any project, the coverage file is generated but ReportGenerator can't parse it (it throws an Object Reference exception). When I remove the attribute filter, everything works fine.

I am using the latest version of altcover and reportgenerator-cli

I have reported the issue both here and in SteveGilham/altcover#28

@danielpalme
Copy link
Owner

danielpalme commented Jul 27, 2018

Seems to be related to #145. Probably a missing attribute in the generated XML.
Can you share a sample XML?

Did you use this release?
https://www.nuget.org/packages/ReportGenerator/4.0.0-rc2

@danielpalme
Copy link
Owner

I'm closing this since it will be fixed in altcover.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants