Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not save the generated Cobertura XML file with a UTF-8 BOM #380

Closed
ahsonkhan opened this issue Sep 3, 2020 · 3 comments
Closed

Do not save the generated Cobertura XML file with a UTF-8 BOM #380

ahsonkhan opened this issue Sep 3, 2020 · 3 comments
Labels
enhancement

Comments

@ahsonkhan
Copy link
Contributor

ahsonkhan commented Sep 3, 2020 •
edited
Loading

Came across this when trying to make sure all files in our repo (including build artifacts) are ASCII-only:
Azure/azure-sdk-for-c#1201
Azure/azure-sdk-for-c#1199

Validating that ./build/Cobertura.xml file only contains ASCII bytes...
1:<?xml version="1.0" encoding="utf-8"?>

cc @danielpalme
This was referenced Sep 3, 2020
Merged
Merged
@danielpalme
Copy link
Owner

Release 4.6.6 contains your PR.

@ahsonkhan
Copy link
Contributor Author

Sweet!

@ahsonkhan
Copy link
Contributor Author

Fixed in #381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielpalme @ahsonkhan