Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puppetlabs/stdlib 9 breaks compatibility with Puppet 6 #77

Open
danielparks opened this issue Jun 4, 2023 · 0 comments
Open

puppetlabs/stdlib 9 breaks compatibility with Puppet 6 #77

danielparks opened this issue Jun 4, 2023 · 0 comments

Comments

@danielparks
Copy link
Owner

My most recent release switched to the stdlib::shell_escape() syntax, which appears to be required by puppetlabs/stdlib (changelog).

I semi-incorrectly reported with as fixing Puppet 8 support, but did not update the metadata to not support Puppet 6. It turns out that Puppet 8 makes deprecations an error by default. See puppetlabs/puppetlabs-stdlib#1365.

One of two things needs to happen:

  • Downgrade to puppetlabs/stdlib < 9 and revert to the shell_escape() syntax. This would maintain support with Puppet 6 through 8.
  • Update metadata to only support Puppet ≥ 7 and puppetlabs/stdlib ≥ 9. This might cause problems for anybody who needs to use an old version of puppetlabs/stdlib, which is particularly likely because of this issue.

I suppose I could try checking for the existence of stdlib::shell_escape and calling the correct function depending on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant