Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Pathname#join #22

Closed
5 tasks
danielpclark opened this issue Jun 15, 2016 · 2 comments
Closed
5 tasks

Implement Pathname#join #22

danielpclark opened this issue Jun 15, 2016 · 2 comments

Comments

@danielpclark
Copy link
Owner

danielpclark commented Jun 15, 2016

Rust seems to have it's own path joining methods. http://rustbyexample.com/std_misc/path.html This "may" do exactly what we want.

  • Write Rust implementation of Pathname#join to FasterPath.join
  • Write refinements and monkey-patches for Pathname#join and map implementation to Pathname.new(result)
  • Write tests proving FasterPath.join operates the same as Pathname#join
  • Write benchmarks in test/benches and compare the performance.
  • Copy benchmarks to test/pbench/pbench_suite.rb
@mrageh
Copy link
Contributor

mrageh commented Jun 17, 2016

@danielpclark I'd like to attempt adding FasterPath.join

@danielpclark
Copy link
Owner Author

Have at it :-)

@danielpclark danielpclark added this to the 0.4.0 milestone May 31, 2017
@danielpclark danielpclark mentioned this issue Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants