Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled mnemonics #48

Closed
schrodyn opened this issue Jan 16, 2024 · 3 comments
Closed

Unhandled mnemonics #48

schrodyn opened this issue Jan 16, 2024 · 3 comments

Comments

@schrodyn
Copy link

schrodyn commented Jan 16, 2024

While bulk processing some files into MCRIT I witnessed some errors related to smda and unhandled mnemonics.

ERROR:smda.intel.IntelInstructionEscaper:********************************************** Unhandled mnemonic: endbr64
ERROR:smda.intel.IntelInstructionEscaper:********************************************** Unhandled mnemonic: vpsllw
ERROR:smda.intel.IntelInstructionEscaper:********************************************** Unhandled mnemonic: vcvtss2sd

Unfortunately I don't have hashes available as it was a bulk job of a large directory of samples. At least endbr64 is a common instruction in ELF files compiled with GCC.

@danielplohmann
Copy link
Owner

danielplohmann commented Jan 17, 2024

Thanks for pointing this out!
I have a list of some more known unhandled instructions locally and will try to fix as many of them as possible in one go, as this will affect the outcome of PicHash calculation and possibly lead to incompatibility and/or mismatches.
Currently, the version of SMDA in MCRIT is already pinned to a commit prior to any changes that affect PicHash things, and whenever I will upgrade the list of instruction handling, I will do add a migration in MCRIT that will allow recalculation and updating of PicHashes for all functions to keep things straight.
The disassembly of SMDA itself however is not affected by these shortcomings in instruction handling at all.

Note to self: fix this against capstone's full list of instructions.

@schrodyn
Copy link
Author

Cheers, Daniel. Looking forward to the changes and thanks for your work on these projects.

@danielplohmann
Copy link
Owner

This has been fixed in smda v1.13.8.
The escaper now covers all instructions known in capstone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants