Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Next 13/React 18? #100

Closed
zargold opened this issue Sep 28, 2023 · 5 comments
Closed

Support for Next 13/React 18? #100

zargold opened this issue Sep 28, 2023 · 5 comments

Comments

@zargold
Copy link

zargold commented Sep 28, 2023

Does this work with React 18, Next 13 maybe with the app directory?

@danielr18
Copy link
Owner

@zargold There's no support for app directory yet.

I released connected-next-router@5.0.0-rc.1 today, which supports Next 13, React 18, and next-redux-wrapper 8.
#102

@felschr
Copy link

felschr commented Nov 2, 2023

5.0.0-rc.1 contains @types/react-redux in the normal dependencies, which might cause conflicts since react-redux@8.0.0 now comes with its own types.

I'm actually not sure how it ended up there, since I can't find it in the package.json of the source, but this from my local node_modules/connectec-next-router/package.json:

  "dependencies": {
    "@types/react-redux": "^7.1.27"
  }

Update: It does seem to prefer the types from react-redux, in my editor at least. Still, this package shouldn't be in dependencies, but at least it doesn't seem to break anything.

@danielr18
Copy link
Owner

Good catch @felschr, thanks!
It probably got there by one of the Snyk PRs. I'll take care of it before releasing the new version.

@felschr
Copy link

felschr commented Nov 2, 2023

You're probably aware already, but Next.js 14 has also recently been released.

@danielr18
Copy link
Owner

Version 5 has been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants