Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to change action types names #53

Closed
vabatta opened this issue Sep 19, 2020 · 1 comment
Closed

Option to change action types names #53

vabatta opened this issue Sep 19, 2020 · 1 comment
Labels
good first issue Good for newcomers

Comments

@vabatta
Copy link

vabatta commented Sep 19, 2020

Would be great to have an option to change the hardcoded type action name such as this one
https://github.com/danielr18/connected-next-router/blob/master/src/actions.ts#L11 .

@danielr18
Copy link
Owner

Hey @vabatta, would you be able to create a PR for this?

If the onLocationChanged function is modified, you can pass the action name from this line:

store.dispatch(onLocationChanged(locationFromUrl(url, as), action))

The part that may be complicated are the types.

@danielr18 danielr18 added the good first issue Good for newcomers label Nov 15, 2020
@vabatta vabatta closed this as not planned Won't fix, can't repro, duplicate, stale Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants