Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key missing array #170

Merged
merged 22 commits into from
Feb 26, 2022
Merged

Key missing array #170

merged 22 commits into from
Feb 26, 2022

Conversation

LiamMartens
Copy link
Collaborator

Arrays of objects should contain _key properties
This edit causes objects in an array to also contain a _key property - "primitive" types remain untouched

danielroe
danielroe reviewed Jan 11, 2022
View reviewed changes
Copy link
Owner

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Would you add a type test for this as well?

@LiamMartens LiamMartens merged commit a5a3494 into danielroe:main Feb 26, 2022
@LiamMartens LiamMartens deleted the key-missing-array branch February 26, 2022 22:22
@danielroe danielroe mentioned this pull request Feb 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LiamMartens @danielroe