This repository has been archived by the owner on Nov 22, 2023. It is now read-only.
Handle safe area bottom inset differently #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for looking into this! I will have a look as soon as possible. |
|
Looks great, thank you for fixing this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2.
Putting a
ScrollViewin a bottom sheet caused the system to put the bottom of the content in the safe area, obscuring some content in many cases.I guess that maybe specifying the
padding(.bottom, geo.safeAreaInsets.bottom)to the content view could be the user's responsibility, because they might intend the view to bleed into the safe area. Maybe it should be an optional 'bleed' setting?