Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subscribeToContextChanges is not subscribing to subscribeToShouldPasteImage and subscribeToShouldPasteImages #11

Closed
MarcosChevis opened this issue Oct 17, 2022 · 2 comments
Closed

subscribeToContextChanges is not subscribing to subscribeToShouldPasteImage and subscribeToShouldPasteImages #11

MarcosChevis opened this issue Oct 17, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@MarcosChevis
Copy link

In RichTextCoordinator the subscribeToContextChanges is not calling the functions subscribeToShouldPasteImage and subscribeToShouldPasteImages.
Because of that, images are not showing on the text editor.
@danielsaidi
Copy link
Owner

Hi @MarcosChevis

Great find, I must have missed that. 👍

I saw your PR, thank you! I'd be happy to merge those subscription changes. However, I have some comments, so let's continue the discussion in the PR.

@danielsaidi
Copy link
Owner

This will be fixed in the next patch version.

@danielsaidi danielsaidi added the bug Something isn't working label Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielsaidi @MarcosChevis