Wrap RichTextCoordinator.syncContextWithTextView() in DispatchQueue #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I got confused with the warning. I thought it was about using the background thread, while in fact this looks like an issue with the SwiftUI SDK in Xcode 14.0. |
|
Hi! Yeah, this has been really confusing and has affected a bunch of my open-source projects. I first started looking into adding async support, but since it causes other problems I decided to wait until Xcode 14.1 to see if it's solved there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode 14 produces runtime warnings for this function, as it updates the UI from a background thread. This PR wraps the function in `DispatchQueue.main.async`. An alternative would be to use `@MainActor`.This PR should get tested before merging!