Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google maps mobile sdk #13

Closed
iBasit opened this issue Feb 26, 2016 · 8 comments
Closed

Google maps mobile sdk #13

iBasit opened this issue Feb 26, 2016 · 8 comments
Milestone

Comments

@iBasit
Copy link
Contributor

iBasit commented Feb 26, 2016

There is no support for this, can you please add it.

It is so difficult to get mobile sdk up and running.

@ihadeed
Copy link
Collaborator

ihadeed commented Mar 10, 2016

This is an interesting plugin ...

I just checked it out, and I was looking at this: https://github.com/mapsplugin/cordova-plugin-googlemaps/wiki/Map

Seems like the plugin doesn't rely on static functions, but relies on class functions instead. My understanding is that the Ionic Native is written to call the plugin's static functions only.

Any thoughts @tlancina ?

@tlancina
Copy link
Contributor

Yeah I'm not sure about this, we have the same issue with the Contacts plugin to some extent as well. We could add it and just expose the properties of the plugin: https://github.com/mapsplugin/cordova-plugin-googlemaps/blob/master/www/googlemaps-cdv-plugin.js#L2537-L2584, but I can't think of a good way for us to wrap the callbacks on the instantiated Map object.

@dmackerman
Copy link

Personally, implementing the Google Maps JS SDK is super simple. Even more so with NG2 now that we don't have to worry about $digest. I've never understood why you'd want the "native" component over just implementing a much more flexible Component with the raw Google JS SDK.

@ihadeed ihadeed mentioned this issue Mar 29, 2016
@mlynch
Copy link
Collaborator

mlynch commented Mar 29, 2016

Would love to expose a native control here if possible!

@ihadeed
Copy link
Collaborator

ihadeed commented Mar 29, 2016

This would be another plugin related to issue #86

@iBasit
Copy link
Contributor Author

iBasit commented Mar 29, 2016

@dmackerman Native Map is a lot faster then JS SDK. Performance is beautiful with native map. Native map also brings some other functionality instantly, where we would have to create thous functionalities with JS SDK, like location pointer.

I have used both SDK on ionic2 and native is 100% better in my opinion.

@ihadeed
Copy link
Collaborator

ihadeed commented Apr 30, 2016

Looks & feels great, the Ionic Native wrapper works now for this plugin. Will complete the API for version 1.3.0
screenshot_20160429-224618

@ghost
Copy link

ghost commented May 17, 2016

@ihadeed please review this issue #161

@ihadeed ihadeed mentioned this issue May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants