Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contacts): remove double import of checkAvailability #2659

Merged
merged 1 commit into from
Aug 25, 2018
Merged

fix(contacts): remove double import of checkAvailability #2659

merged 1 commit into from
Aug 25, 2018

Conversation

paxtonhare
Copy link
Contributor

Fixes #2626

@danielsogl danielsogl changed the title fixing double import of checkAvailability fix(contacts): remove double import of checkAvailability Aug 25, 2018
@danielsogl danielsogl added the target: patch This PR is targeted for the next patch release label Aug 25, 2018
@danielsogl danielsogl changed the title fix(contacts): remove double import of checkAvailability fixing double import of checkAvailability Aug 25, 2018
@danielsogl danielsogl changed the title fixing double import of checkAvailability fix(contacts): remove double import of checkAvailability Aug 25, 2018
@danielsogl danielsogl merged commit 1ad4cc1 into danielsogl:v5 Aug 25, 2018
@dschoeni
Copy link

dschoeni commented Sep 4, 2018

This isn't fixed in the newest release - If you download the package using NPM:

https://registry.npmjs.org/@ionic-native/contacts/-/contacts-5.0.0-beta.17.tgz

You can check in the ngx/index.js and index.js file that a double-import still happens:

L17:

import { IonicNativePlugin, checkAvailability, cordovaInstance, instanceAvailability, instancePropertyGet, instancePropertySet, checkAvailability, getPromise } from '@ionic-native/core';

I guess its fixed in the TypeScript sources, but not in the compiled release on NPM?

@JavyMB
Copy link

JavyMB commented Sep 17, 2018

Just like @dschoeni mention, This isn't fixed.
Using NPM:
npm install --save @ionic-native/contacts@5.0.0-beta.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants