fix wrapEventObservable #2660
Merged
fix wrapEventObservable #2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch ... we were calling Thanks |
ihadeed
approved these changes
Aug 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I almost sure (after some debugging) that it should fix a problem with the latest beta (5.0.0-beta.15) due to this change which have been merged : #2622
My problem is that Network.onConnect() throws an error with the latest v5 (but worked with 5.0.0-beta.14). The error is "RangeError: Maximum call stack size exceeded" because rxjs try to subscribe to the "document" string instead of document object.
I think it should be easy to reproduce.