Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(open-native-settings): allow supported input #2666

Merged
merged 2 commits into from
Aug 31, 2018

Conversation

briznad
Copy link
Contributor

@briznad briznad commented Aug 27, 2018

This pull request fixes issue #2665

The open-native-settings plugin doesn't allow input which is supported by the underlying Cordova-open-native-settings plugin (https://github.com/guyromb/Cordova-open-native-settings).

As the underlying plugin author explains:

In Android, by default [Settings] is opened in the same application as a new activity… In order to open settings as a new application (two applications will appear in "recent/opened" apps list) the following code can be used: window.cordova.plugins.settings.open(["wifi", true]); ....

However, in index.ts the only accepted input is a string, making the advanced option unobtainable.

This fixes that.

@briznad briznad changed the title [bug: 2665][open-native-settings] allow supported input [open-native-settings] allow supported input Aug 27, 2018
@danielsogl danielsogl added the target: patch This PR is targeted for the next patch release label Aug 28, 2018
@danielsogl danielsogl changed the title [open-native-settings] allow supported input fix(open-native-settings): allow supported input Aug 30, 2018
@danielsogl danielsogl merged commit be0dc3d into danielsogl:master Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants