Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firebase-x): update types to match cordova-plugin-firebasex 7.0.0 #3226

Merged
merged 3 commits into from Nov 19, 2019

Conversation

SnaiCrys
Copy link
Contributor

@SnaiCrys SnaiCrys commented Nov 11, 2019

  • (Android) BREAKING CHANGE Rework verifyPhoneNumber()
    • Remove redundant verified in returned credentials object.
    • Support mocking of instant verification for verifyPhoneNumber() on Android for integration testing.
  • (iOS) BREAKING CHANGE Rework verifyPhoneNumber()
    • Return the same credential object structure as Android.
  • Add signInWithCredential() to sign user into Firebase account and linkUserWithCredential() to link user account with credentials obtained via verifyPhoneNumber().
  • (iOS) Add getAPNSToken() plugin API method to get the APNS token on iOS.
  • (iOS) Add onApnsTokenReceived() to register a callback function to be invoked when the APNS token is allocated.

* Add getAPNSToken() plugin API method to get the APNS token on iOS.
* (iOS) Add `onApnsTokenReceived()` to register a callback function to be invoked when the APNS token is allocated.
@SnaiCrys SnaiCrys marked this pull request as ready for review November 11, 2019 17:09
@l3ender
Copy link

l3ender commented Nov 15, 2019

Given that there are breaking changes, this will probably need to be in the next Ionic major release. Could anyone on the Ionic team comment on when this could be included and released?

@danielsogl danielsogl self-assigned this Nov 19, 2019
@danielsogl danielsogl added the target: patch This PR is targeted for the next patch release label Nov 19, 2019
@danielsogl danielsogl merged commit 2fd4885 into danielsogl:master Nov 19, 2019
@SnaiCrys SnaiCrys deleted the patch-1 branch November 19, 2019 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants