Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(in-app-browser): add "beforeload" callback method #3249

Merged
merged 3 commits into from Dec 9, 2019

Conversation

mread1208
Copy link
Contributor

Addressing issue #3152 for version 4 of this plugin.

@mread1208
Copy link
Contributor Author

Since we're still using Ionic v3, we're using "@ionic-native/in-app-browser": "^4.20.0" of this plugin. Is it possible to merge into the v4 branch or do I need to make this fix in master and just point to my forked version for the time being until we update our app to Ionic v4?

@danielsogl danielsogl changed the title fix(in-app-browser): Missing "beforeload" callback method feat(in-app-browser): add "beforeload" callback method Dec 9, 2019
@danielsogl danielsogl self-assigned this Dec 9, 2019
@danielsogl danielsogl added the target: patch This PR is targeted for the next patch release label Dec 9, 2019
@danielsogl danielsogl merged commit a1b7af4 into danielsogl:v4 Dec 9, 2019
danielsogl pushed a commit that referenced this pull request Dec 9, 2019
* fix(in-app-browser): Added missing callback method on the "beforeload" event ([issue#3152](#3152))

* fix(in-app-browser): Missing "beforeload" callback method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants