New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(network): declare connection enum with strings #3630

Merged

danielsogl merged 1 commit into danielsogl:master from NoelDeMartin:patch-1

Apr 5, 2021

Contributor

NoelDeMartin commented Feb 25, 2021

This enum was introduced in #2754 but it is declared with numbers, which may cause issues when doing something like:

this.network.type === Connection.NONE

Typescript will complain that this.network.type is a string and Connection.NONE is a number.


          [Network] Declare Connection enum with strings

e6b0f4a

danielsogl changed the title ~~[Network] Declare Connection enum with strings~~ feat(network): declare connection enum with strings

danielsogl approved these changes

View reviewed changes

danielsogl merged commit d698d59 into danielsogl:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment