Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firebase-x, increment should have 2 parameters #3970

Closed
MauriceSchoenmakers opened this issue Jan 11, 2022 · 1 comment · Fixed by #4010
Closed

firebase-x, increment should have 2 parameters #3970

MauriceSchoenmakers opened this issue Jan 11, 2022 · 1 comment · Fixed by #4010

Comments

@MauriceSchoenmakers
Copy link

MauriceSchoenmakers commented Jan 11, 2022

I'm submitting a ... (check one with "x")
[x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://ionicworldwide.herokuapp.com/

Current behavior:
FirebaseX.incrementCounter has two parameters, now we get a type error when we pass 2 parameters

Expected behavior:
correct typescript type

Steps to reproduce:

Related code:

insert any relevant code here

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):

insert the output from ionic info here
@danielsogl
Copy link
Owner

Feel free to adjust the interface and create a pull request. I will review your changes: https://github.com/danielsogl/awesome-cordova-plugins/blob/master/src/%40awesome-cordova-plugins/plugins/firebase-x/index.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants