feat(smartlook): rewrite smartlook ionic plugin #4510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 1, 2023
|
@danielsogl Hey! I'm sorry for the pingy ping, but is there any chance this gets merged and tagged? Its blocking quite a lot of our customers from upgrading. Thanks a lot! |
|
There has been no recent activity and this PR has been marked inactive. |
|
A Smartlook and Capacitor user here. Just pinging this PR to get it merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I'm a mobile SDK dev at Smartlook and we have just released a brand new rewrite of our Cordova plugin.
This PR mirrors the changes into the
Ionic pluginwrapper.Everything was tested locally on
Capacitorwith bothReactandAngulardemo apps.