Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where to find real documentations? #4716

Closed
weihsth opened this issue Jan 17, 2024 · 1 comment
Closed

Where to find real documentations? #4716

weihsth opened this issue Jan 17, 2024 · 1 comment

Comments

@weihsth
Copy link

weihsth commented Jan 17, 2024

Hi there,

I try to find the real documentation for InAppBrowser for ionic/angular project.

The given link goes to https://github.com/danielsogl/awesome-cordova-plugins/tree/master/docs/plugins/in-app-browser. But this is not even nearly correct documentation, because the interface is a completely different one (for example the "addEventListener" is not available), when I import the Pugin from @awesome-cordova-plugins/in-app-browser/ngx.

I need to write this:
this.iaBrowserRef.on('loadstop').subscribe(...)

But for desktop/electron this line does throw an error.

Is there any documentation about the ngx-wrapper Interface?

Regards

@weihsth
Copy link
Author

weihsth commented Jan 17, 2024

Never mind, found the documented code here: node_modules/@awesome-cordova-plugins/in-app-browser/ngx/index.d.ts

That's not the complete documentation, because on desktop, the native window.open() is used and a differnet object is returned, where no subscription to on('loadstop') will work, but that's another issue I guess?

But would be nice and helpful to have it more readable as html documentation somewhere.

@weihsth weihsth closed this as completed Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant