Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firebase-x): setConfigSettings function input parameters aligned with firebase-x plugin #4757

Merged

Conversation

turanofff
Copy link
Contributor

Function setConfigSettings was using incorrect input arguments settings: any wheres firebase-x cordova plugin doc specifies correct arguments:

Parameters:

  • {integer} fetchTimeout - fetch timeout in seconds.
    • Default is 60 seconds.
    • Specify as null value to omit setting this value.
  • {integer} minimumFetchInterval - minimum fetch inteval in seconds.
    • Default is 12 hours.
    • Specify as null value to omit setting this value.
    • Set to 0 to disable minimum interval entirely (DO NOT do this in production)
  • {function} success - callback function to be call on successfully setting the remote config settings
  • {function} error - callback function which will be passed a {string} error message as an argument

@danielsogl danielsogl merged commit adb330a into danielsogl:master Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants