Ignore comments doesn't work

[m99coder]

Hi Daniel,

I'm using buddy.js in version 0.7.0:

./node_modules/buddy.js/bin/buddy --version

My source snippet is:

return b = Math.random() * 16, (a === 'y' ? (b & 3 | 8) : (b | 0)).toString(16); // buddy ignore: line

Calling buddy.js returns warnings:

./snippet.js:1 | return b = Math.random() * 16, (a === 'y' ? (b & 3 | 8) : (b | 0)).toString(16); // buddy ignore: line
./snippet.js:1 | return b = Math.random() * 16, (a === 'y' ? (b & 3 | 8) : (b | 0)).toString(16); // buddy ignore: line
./snippet.js:1 | return b = Math.random() * 16, (a === 'y' ? (b & 3 | 8) : (b | 0)).toString(16); // buddy ignore: line
./snippet.js:1 | return b = Math.random() * 16, (a === 'y' ? (b & 3 | 8) : (b | 0)).toString(16); // buddy ignore: line

 4 magic numbers found across 6 files

Did I miss something?

With kind regards
Marco

[danielstjules]

Replace // buddy ignore: line with // buddy ignore:line and that'll fix that! :) It's just that one extra space. I'm not doing anything fancy for matching, so it expects an exact string match. Given its behaviour, I figure this eliminates any possibility of false positives.

[m99coder]

You are right. That works. Thanks.

[danielstjules]

No problem! Happy to help.