Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern matching in condition with literals generates incorrect code #1147

Closed
edemaine opened this issue Apr 4, 2024 · 0 comments · Fixed by #1200
Closed

Pattern matching in condition with literals generates incorrect code #1147

edemaine opened this issue Apr 4, 2024 · 0 comments · Fixed by #1200
Labels
bug Something isn't working

Comments

@edemaine
Copy link
Collaborator

edemaine commented Apr 4, 2024

if {type: "Identifier", name: "Infinity"} := end
  true

generates this invalid code:

let ref;if ((ref = end) && 'type' in ref && ref.type === "Identifier" && 'name' in ref && ref.name === "Infinity") {
  const {type: "Identifier", name: "Infinity"} = ref;
  true
}

Regular expressions are similarly problematic.

@edemaine edemaine added the bug Something isn't working label Apr 4, 2024
@edemaine edemaine changed the title Pattern matching with literals generates incorrect code Pattern matching in condition with literals generates incorrect code Apr 29, 2024
edemaine added a commit that referenced this issue Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant