Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with the chord function #1

Closed
b2renger opened this issue Jan 6, 2017 · 2 comments
Closed

Issue with the chord function #1

b2renger opened this issue Jan 6, 2017 · 2 comments

Comments

@b2renger
Copy link

b2renger commented Jan 6, 2017

It seems that when calling

chord('Bb7')

I get ["Bb7", "D8", "F8"] where I should get ["Bb", "D", "F","Ab"] as mentioned in the readme.

Apparently the function understands the 7 as an octave parameter and not as a dominant 7th.
But when I build it like this

chord('7','Bb') I do get the right result though.

@danigb
Copy link
Owner

danigb commented Jan 10, 2017

Hi @b2renger

Thanks for test this library 👍 . Unfortunately this is deprecated and all the development moved to tonal: https://github.com/danigb/tonal (it's my fault I did't write a notice in readme, sorry).

With tonal you should write:

var tonal = require('tonal')
t.chord('Bb7') // => [ 'Bb', 'D', 'F', 'Ab' ]

Hope it helps.

@danigb danigb closed this as completed Jan 10, 2017
@b2renger
Copy link
Author

thanks for the answer and thanks for the lib (and the soundfont-player one !). I'll check tonal :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants