Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code for dreamerv2 baseline doesn't work #2

Closed
zhixuan-lin opened this issue Oct 21, 2021 · 1 comment
Closed

Code for dreamerv2 baseline doesn't work #2

zhixuan-lin opened this issue Oct 21, 2021 · 1 comment

Comments

@zhixuan-lin
Copy link

Hello,

First thanks for making this awesome lightweight environment! I'm trying to run the dreamerv2 baseline in this repo but the code doesn't work. Clearly, it is because dv2.configs is a dict so dv2.configs.crafter would cause error.

When I looked at the dreamerv2 code and tried to fix it, I got a bit confused about how configurations are handled (e.g., there is a crafter entry in configs.yaml but the --configs flag doesn't seem to do anything...). Also, I saw your reply to an issue that indicates the right hyperparameters for Crafter, but these are not present in this repo (i.e. main.py), nor in the dreamerv2 repo.

So I wonder if you can point out what's the exact way to reproduce the dreamerv2 results on crafter with the right hyperparameters? It would be even better if you could just provide a runnable version in this baseline repo. Many thanks!

@danijar
Copy link
Owner

danijar commented Dec 14, 2021

Thanks, fixed!

@danijar danijar closed this as completed Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants