Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collaboration #1

Closed
danimtb opened this issue Jul 11, 2017 · 3 comments
Closed

Collaboration #1

danimtb opened this issue Jul 11, 2017 · 3 comments

Comments

@danimtb
Copy link
Owner

danimtb commented Jul 11, 2017

Hi @JulianKahnert!

This is my dasshio repository. It was originally cloned from your amazon-dashbutton one (https://github.com/JulianKahnert/amazon-dashbutton). As you can see is pretty much the same but I have changed its shape to work as a Hass.io add-on.

I know it is not a big thing, but as I took your work as a basis, I would like to show you this kind of fork and collaborate if you are interested on a hass.io integration like this.

Cheers!

Edit: I have not forked you repo directly because it think this is something different. However, if you'd like so I can fork it and cherrypick the changes. Just tell me! Thanks

@JulianKahnert
Copy link
Contributor

Hi,
thanks for your kind words. Since my repo is already a fork, its ok with me. But I think it would be nice, if you could mention the original sources, e.g.:

Sources & Inspiration:
- [Raspberry Pi script](https://github.com/vancetran/amazon-dash-rpi)
- [Maddox Dashbutton Repo](https://github.com/maddox/dasher)
- [General Amazon Dash Hack](https://medium.com/@edwardbenson/how-i-hacked-amazon-s-5-wifi-button-to-track-baby-data-794214b0bdd8#.n6fhd3z40)

I am very happy that we will get a dashbutton plugin in hass.io! 🙂

@danimtb
Copy link
Owner Author

danimtb commented Jul 13, 2017

Nice. I will incorporate those sources as well as your forked repo to the readme documentation.

Thank you! 😃

@danimtb
Copy link
Owner Author

danimtb commented Aug 20, 2017

Credit section updated and Sources & Inspiration section added

@danimtb danimtb closed this as completed Aug 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants