Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncdirect ought initialize readline only on demand #1326

Closed
dankamongmen opened this issue Feb 3, 2021 · 0 comments
Closed

ncdirect ought initialize readline only on demand #1326

dankamongmen opened this issue Feb 3, 2021 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone

Comments

@dankamongmen
Copy link
Owner

See #1325. I think we ought remove NCDIRECT_OPTION_NO_READLINE entirely, and instead support a new function, ncdirect_readline(). This function will initialize libreadline upon first use. That way, it's never initialized unless it's needed, this flag is never necessary, and the proper way to use readline is clearly indicated.

@dankamongmen dankamongmen added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 3, 2021
@dankamongmen dankamongmen added this to the 2.2.0 milestone Feb 3, 2021
@dankamongmen dankamongmen self-assigned this Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant