Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ncplane_as_rgba() needs be brought up to date #1579

Closed
dankamongmen opened this issue Apr 22, 2021 · 2 comments
Closed

ncplane_as_rgba() needs be brought up to date #1579

dankamongmen opened this issue Apr 22, 2021 · 2 comments
Assignees
@dankamongmen
Labels
bug Something isn't working duplicate This issue or pull request already exists
Milestone
2.4.0

Comments

@dankamongmen
Copy link
Owner

ncplane_rgba() is old and needs updating. It doesn't currently implement NCVISUAL_OPTION_HORALIGNED nor NCVISUAL_OPTION_VERALIGNED, and I doubt that it works for NCBLIT_PIXEL (maybe it does?). It's not the most critical thing in the world, but it's better if it works than doesn't work.
@dankamongmen dankamongmen added the bug Something isn't working label Apr 22, 2021
@dankamongmen dankamongmen added this to the 3.0.0 milestone Apr 22, 2021
@dankamongmen dankamongmen self-assigned this Apr 22, 2021
@dankamongmen
Copy link
Owner Author

is this a duplicate of #1490?

@dankamongmen dankamongmen changed the title ncplane_rgba() needs be brought up to date ncplane_as_rgba() needs be brought up to date May 24, 2021
@dankamongmen dankamongmen added the duplicate This issue or pull request already exists label May 24, 2021
@dankamongmen
Copy link
Owner Author

it is indeed a duplicate of #1490

@dankamongmen dankamongmen modified the milestones: 3.0.0, 2.4.0 Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dankamongmen dankamongmen

Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
2.4.0
Development

No branches or pull requests
1 participant
@dankamongmen