Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow escapes through to output #375

Closed
dankamongmen opened this issue Feb 23, 2020 · 1 comment
Closed

Don't allow escapes through to output #375

dankamongmen opened this issue Feb 23, 2020 · 1 comment
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation nonfix closed without a successful fix (invalid, wontfix)
Milestone

Comments

@dankamongmen
Copy link
Owner

I'm kinda shocked I never thought about this, but we oughtn't be allowing escape through to output, much like we don't allow NULs or newlines. Pretty obvious reasons.

@dankamongmen dankamongmen added bug Something isn't working documentation Improvements or additions to documentation labels Feb 23, 2020
@dankamongmen dankamongmen added this to the 1.3.0 milestone Feb 23, 2020
@dankamongmen dankamongmen self-assigned this Feb 23, 2020
@dankamongmen
Copy link
Owner Author

ESC is a control character, and iscntrl(3) returns true for it.

static int
term_putc(FILE* out, const egcpool* e, const cell* c){
  if(cell_simple_p(c)){
    if(c->gcluster == 0 || iscntrl(c->gcluster)){

so this is already handled.

@dankamongmen dankamongmen added the nonfix closed without a successful fix (invalid, wontfix) label Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation nonfix closed without a successful fix (invalid, wontfix)
Projects
None yet
Development

No branches or pull requests

1 participant