Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should have a function to attach elements to a wire #51

Closed
dankelley opened this issue Dec 9, 2023 · 1 comment
Closed

should have a function to attach elements to a wire #51

dankelley opened this issue Dec 9, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request
Projects

Comments

@dankelley
Copy link
Owner

If an instrument is attached to a wire via a clamp, its height value ought not to be added to the total length of the mooring. For deep-ocean moorings with say 10 instruments of height 0.5m each, this is not an issue that matters much. However, it will matter for short moorings (like a 2-metre mooring of issue #47).

Some instruments have words like 'clamp on' in their names, but still have nonzero height values within their description. I suppose it would be worth changing that, but there is also the possibility of a new function to indicate that something is clamped on.

This could be a function like the following

clampon <- function(i) {
   i$height <- 0
   i
}
@dankelley dankelley added the enhancement New feature or request label Dec 9, 2023
@dankelley dankelley self-assigned this Dec 9, 2023
@github-actions github-actions bot added this to To do in Issues Dec 9, 2023
@dankelley
Copy link
Owner Author

I added clamped() to the "main" branch, commit 7b50baf; see the examples for ?clamped (or https://dankelley.github.io/mooring/reference/clamped.html) to see it in action.

Issues automation moved this from To do to Done Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Issues
  
Done
Development

No branches or pull requests

1 participant