Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to add a block in Moodle 2.9 together with mod_attendance (commit 24.08.2015) #10

Closed
Kathrin84 opened this issue Sep 1, 2015 · 9 comments

Comments

@Kathrin84
Copy link

Hi Dan,

I took both, the newest versions from block_attendance and mod_attendance from gitHub. Always when I wanted to add the block to my course, following notice/error occured and crashed my course:

Notice: Undefined property: attendance::$perm in /var/www/html/moodle_dev/blocks/attendance/block_attendance.php on line 79

Fatal error: Call to a member function can_take() on a non-object in /var/www/html/moodle_dev/blocks/attendance/block_attendance.php on line 79

Kind regards,
Kathrin

@Syxton
Copy link

Syxton commented Sep 2, 2015

We are also seeing this issue. It also makes it impossible to view assignments in those courses. This is a serious blocker for us.

@glydetech
Copy link

I'm seeing the same issue. I've checked over the mod_attendance and 'perm' doesn't appear to be defined as an object property. My workaround is simply commenting out the conditionals in blocks/attendance/block_attendance.

@Canx
Copy link

Canx commented Sep 19, 2015

Same problem here, I will also try removing conditionals

@danmarsden
Copy link
Owner

sorry guys, I've been working on the attendance activity in the master branch and tidying up some weird code. I didn't see this earlier because for some reason I wasn't subscribed to the issues tracker in github for this project (until now) which seems really weird... I'll get this sorted now.

@danmarsden
Copy link
Owner

Fix now in the master branch here. You will also need to update the attendance activity mod with the latest from the master branch because I've added a dependency to the block. Thanks for the report and apologies for the delay on this one!

@Kathrin84
Copy link
Author

Hi Dan,
thanks for resolving this issue. :)

@Kathrin84
Copy link
Author

Could you please update your code in the Moodle plugin repo. There, the code is not up to date. Updating plugins with the Moodle internal procedure is way more comfortable.
That would be great!

@danmarsden
Copy link
Owner

not yet.... you must have picked up the mod_attendance plugin from the github repo to get this error in the first place. I don't update the plugins repo immediately after bumping the version in github to allow more advanced users to pick up any issues before we release it to the masses. :-)

@glydetech
Copy link

This appears to fix the issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants