Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recompleiton message from site main adminstrator' email address #23

Open
duranchen opened this issue Oct 11, 2019 · 3 comments
Open

Recompleiton message from site main adminstrator' email address #23

duranchen opened this issue Oct 11, 2019 · 3 comments

Comments

@duranchen
Copy link

in most cases, I think the recompletion message should be sent from support email address, if
support email address is not configured on Moodle, it should be sent from noreply email address, instead of site adminstrator's email address.

@efaktorgithub
Copy link

Dan, it seems that the local_recompletion not respect the setting "emailstop = 1" in the database. So when testing it, it sends emails to all users that is reset. In PROD it doesn't matter, but is this something you will fix?
Else we can do it and send you the patch.

Else: this it a nice plugin and does the job!

Alf Martin Johnsen
EFAKTOR AS

@danmarsden
Copy link
Owner

@efaktorgithub - the plugin uses the moodle core email_to_user function which is why the user profile field emailstop isn't used.
Eloy covers this detail here:
https://tracker.moodle.org/browse/MDL-40669?focusedCommentId=687267&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-687267

it sounds like "emailstop" was probably the wrong name for that setting as it doesn't prevent email from being sent to the user.

@danmarsden
Copy link
Owner

(great to hear you find it useful!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants