Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other plugins impelmetnation #35

Closed
lukascelinak opened this issue Feb 1, 2021 · 3 comments
Closed

Other plugins impelmetnation #35

lukascelinak opened this issue Feb 1, 2021 · 3 comments

Comments

@lukascelinak
Copy link
Contributor

Hi, i have solution for archives,
if would not be beter to storage all archived data in one table, as json data, for example:

quiz->idnumber= array(quiz_attempts->idnumber= array("quiz_attempt_row"),)
ad so,
scheme
module->id=array_of_archived_tables(module_table=table_row);

@danmarsden
Copy link
Owner

What problem would that solve? How would you report on the json data?

When this table gets big it would be really hard to work with as you would have to get all records from the table, decode json and then filter it to find the data wanted in the report.

The better solution would be to implement archival support into each activity plugin.

@lukascelinak
Copy link
Contributor Author

I agree with implementing of archival support into each activity plugin,
I
had implemented it in my own plugins via archived / deleted atribute in each table, where im storaging user attempts or data for grading and completion.

But how to do it for core LMS Moodle plugins?

I just tried json for lessson module (3 tables) but lesson is really messy in db, that should make problems with storage in future, like you said.

@danmarsden
Copy link
Owner

We'd need to push the code into the core Moodle release - (quite a big project)

I'm closing this off as I don't think json encoding is going to help anything here - happy to review pull requests with improvements though (still need to get to that LTI pull request... hopefully this week or next!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants