Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve usability of "Save attendance" to make it clear it will load the next list of users. #360

Closed
derrynj opened this issue Jan 23, 2019 · 5 comments

Comments

@derrynj
Copy link

derrynj commented Jan 23, 2019

Moodle 3.6.1+ (Build: 20181214)
Attendance plugin version: 3.6.3 (2018102600)

When taking attendance for a session, the totals at the bottom of the table do not update when you click 'Save attendance'. They only seem to update when you navigate away and then back to the same page.

@danmarsden
Copy link
Owner

Hi Derrynj - I've just had a look, and it seems to work ok for me. The totals at the bottom of the page are for the current page - what isn't always clear though, is hitting the "Save attendance" will take you to the next page of users and it will show you the totals for the "new page"

Can you please verify this and let me know?

thanks,

@derrynj
Copy link
Author

derrynj commented Jan 31, 2019

Hi Dan,
That's exactly what's happening. It took me a few goes to figure out exactly what you were saying but yes that's what I'm seeing.
Is it possible to have some sort of indication there pointing out to the user that the totals are only applicable to the current page?
It's also extremely confusing behavior that it automatically pushes you onto the next page - especially if you only marked a few students attendance.
Cheers,
Derryn

@danmarsden
Copy link
Owner

yeah - this is behaviour that's been there since I took over the plugin, and I agree it's not very clear. There are a few things we can do to improve this - probably change the "save attendance" button text to something like "save and show next page" and tidy up the headers around the totals at the bottom makes sense too. I'll leave this open and try to get to that the next time I'm working on this.

@danmarsden danmarsden changed the title Totals displayed underneath single session table doesn't update when you "Save attendance" Improve usability of "Save attendance" to make it clear it will load the next list of users. Jan 31, 2019
@abhimanyuZ
Copy link

abhimanyuZ commented Mar 27, 2019

Hello Sir,
I was planning to work on this.
I'll edit the button text as "Save and Next". Also i'll add the heading "Totals for listed users:" before the totals at the bottom.

But here is a query:

tidy up the headers around the totals

You meant?
Thanks

@danmarsden
Copy link
Owner

Hi there - I meant change the heading above the totals at the bottom like you suggest - I would probably go for a string like "Totals for this page" - instead of "Totals for listed users.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants